mbutrovich merged PR #2010:
URL: https://github.com/apache/datafusion-comet/pull/2010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
akupchinskiy commented on code in PR #2010:
URL: https://github.com/apache/datafusion-comet/pull/2010#discussion_r2215762841
##
native/proto/src/proto/expr.proto:
##
@@ -80,7 +80,8 @@ message Expr {
ArrayInsert array_insert = 58;
MathExpr integral_divide = 59;
ToP
andygrove commented on code in PR #2010:
URL: https://github.com/apache/datafusion-comet/pull/2010#discussion_r2215684316
##
native/proto/src/proto/expr.proto:
##
@@ -80,7 +80,8 @@ message Expr {
ArrayInsert array_insert = 58;
MathExpr integral_divide = 59;
ToPret
mbutrovich commented on code in PR #2010:
URL: https://github.com/apache/datafusion-comet/pull/2010#discussion_r2213341348
##
native/spark-expr/src/nondetermenistic_funcs/randn.rs:
##
@@ -0,0 +1,265 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more co
akupchinskiy commented on code in PR #2010:
URL: https://github.com/apache/datafusion-comet/pull/2010#discussion_r2212698030
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -2765,6 +2765,26 @@ class CometExpressionSuite extends CometTestBase with
Adap
akupchinskiy commented on code in PR #2010:
URL: https://github.com/apache/datafusion-comet/pull/2010#discussion_r2211570646
##
native/spark-expr/src/nondetermenistic_funcs/randn.rs:
##
@@ -0,0 +1,265 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
akupchinskiy commented on code in PR #2010:
URL: https://github.com/apache/datafusion-comet/pull/2010#discussion_r2211570646
##
native/spark-expr/src/nondetermenistic_funcs/randn.rs:
##
@@ -0,0 +1,265 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
mbutrovich commented on code in PR #2010:
URL: https://github.com/apache/datafusion-comet/pull/2010#discussion_r2210833524
##
native/spark-expr/src/nondetermenistic_funcs/randn.rs:
##
@@ -0,0 +1,265 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more co
mbutrovich commented on code in PR #2010:
URL: https://github.com/apache/datafusion-comet/pull/2010#discussion_r2210768385
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -2765,6 +2765,26 @@ class CometExpressionSuite extends CometTestBase with
Adapti
mbutrovich commented on PR #2010:
URL:
https://github.com/apache/datafusion-comet/pull/2010#issuecomment-3079038284
> In those scenarios we do have reproducibility and I believe a native
implementation should also have this property.
Thank you for the great explanation! This makes se
akupchinskiy commented on code in PR #2010:
URL: https://github.com/apache/datafusion-comet/pull/2010#discussion_r2209889591
##
native/spark-expr/src/nondetermenistic_funcs/randn.rs:
##
@@ -0,0 +1,265 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
akupchinskiy commented on code in PR #2010:
URL: https://github.com/apache/datafusion-comet/pull/2010#discussion_r2209806943
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -2765,6 +2765,26 @@ class CometExpressionSuite extends CometTestBase with
Adap
akupchinskiy commented on PR #2010:
URL:
https://github.com/apache/datafusion-comet/pull/2010#issuecomment-3077747073
> Thanks @akupchinskiy! I have a few questions. The big one for me is: does
the seed state per partition match Spark's behavior, in particular the life
cycle? If the seed g
mbutrovich commented on code in PR #2010:
URL: https://github.com/apache/datafusion-comet/pull/2010#discussion_r2208611091
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -2765,6 +2765,26 @@ class CometExpressionSuite extends CometTestBase with
Adapti
akupchinskiy commented on PR #2010:
URL:
https://github.com/apache/datafusion-comet/pull/2010#issuecomment-3073425800
> Looks like we might need to update this to use the new serde map to
resolve the merge conflict. I can take a look tomorrow if you don't get a
chance, that way we can kick
mbutrovich commented on PR #2010:
URL:
https://github.com/apache/datafusion-comet/pull/2010#issuecomment-3070981508
Looks like we might need to update this to use the new serde map to resolve
the merge conflict. I can take a look tomorrow if you don't get a chance, that
way we can kick off
codecov-commenter commented on PR #2010:
URL:
https://github.com/apache/datafusion-comet/pull/2010#issuecomment-3058219290
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/2010?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
17 matches
Mail list logo
