akupchinskiy commented on code in PR #2010:
URL: https://github.com/apache/datafusion-comet/pull/2010#discussion_r2209806943
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -2765,6 +2765,26 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("randn expression with random parameters") {
+ val partitionsNumber = Random.nextInt(10) + 1
Review Comment:
> Why random values if we only run it once? I see that `"rand expression
with random parameters"` already did this, but it feels like we could get lucky
with a simple test case only running it one time. I guess I should double check
if we seed this RNG (I know we modified some other tests to use fixed seeds).
@mbutrovich Initial idea was testing an invariant that we have the same
result as spark for arbitrary parameters. Do you think it would be better
having several explicit test cases sharing the same seed but having different
batch_size partition_size configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
