Re: [PR] feat: implement predicate adaptation for nested structs [datafusion]

kosiew commented on code in PR #16589: URL: https://github.com/apache/datafusion/pull/16589#discussion_r2179456400 ## datafusion/physical-expr-adapter/src/schema_rewriter.rs: ## @@ -97,13 +101,111 @@ impl<'a> PhysicalExprSchemaRewriter<'a> { &self, expr: Arc,

Re: [PR] feat: implement predicate adaptation for nested structs [datafusion]

kosiew commented on code in PR #16589: URL: https://github.com/apache/datafusion/pull/16589#discussion_r2179456400 ## datafusion/physical-expr-adapter/src/schema_rewriter.rs: ## @@ -97,13 +101,111 @@ impl<'a> PhysicalExprSchemaRewriter<'a> { &self, expr: Arc,

Re: [PR] feat: implement predicate adaptation for nested structs [datafusion]

kosiew commented on code in PR #16589: URL: https://github.com/apache/datafusion/pull/16589#discussion_r2179451974 ## datafusion/physical-expr-adapter/Cargo.toml: ## @@ -0,0 +1,30 @@ +[package] +name = "datafusion-physical-expr-adapter" +description = "Physical expression schema

Re: [PR] feat: implement predicate adaptation for nested structs [datafusion]

adriangb commented on code in PR #16589: URL: https://github.com/apache/datafusion/pull/16589#discussion_r2179009066 ## datafusion/physical-expr-adapter/src/schema_rewriter.rs: ## @@ -97,13 +101,111 @@ impl<'a> PhysicalExprSchemaRewriter<'a> { &self, expr: Arc,

Re: [PR] feat: implement predicate adaptation for nested structs [datafusion]

adriangb commented on code in PR #16589: URL: https://github.com/apache/datafusion/pull/16589#discussion_r2178261730 ## datafusion/physical-expr-adapter/src/schema_rewriter.rs: ## @@ -97,13 +101,111 @@ impl<'a> PhysicalExprSchemaRewriter<'a> { &self, expr: Arc,

Re: [PR] feat: implement predicate adaptation for nested structs [datafusion]

kosiew commented on code in PR #16589: URL: https://github.com/apache/datafusion/pull/16589#discussion_r2177077207 ## datafusion/physical-expr-adapter/README.md: ## @@ -0,0 +1,14 @@ +# DataFusion Physical Expression Adapter + +This crate provides physical expression schema adapt

Re: [PR] feat: implement predicate adaptation for nested structs [datafusion]

adriangb commented on PR #16589: URL: https://github.com/apache/datafusion/pull/16589#issuecomment-3021717859 @alamb I've reworked this as per discussion in https://github.com/apache/datafusion/pull/16589#discussion_r2176012085. This now leaves the actual casting work up the cast functions,

Re: [PR] feat: implement predicate adaptation for nested structs [datafusion]

alamb commented on code in PR #16589: URL: https://github.com/apache/datafusion/pull/16589#discussion_r2176112016 ## datafusion/physical-expr-adapter/src/schema_rewriter.rs: ## @@ -0,0 +1,811 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

Re: [PR] feat: implement predicate adaptation for nested structs [datafusion]

adriangb commented on code in PR #16589: URL: https://github.com/apache/datafusion/pull/16589#discussion_r2176101815 ## datafusion/physical-expr-adapter/src/schema_rewriter.rs: ## @@ -0,0 +1,811 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

Re: [PR] feat: implement predicate adaptation for nested structs [datafusion]

alamb commented on code in PR #16589: URL: https://github.com/apache/datafusion/pull/16589#discussion_r2176012085 ## datafusion/physical-expr-adapter/src/schema_rewriter.rs: ## @@ -0,0 +1,811 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut