adriangb commented on PR #16589: URL: https://github.com/apache/datafusion/pull/16589#issuecomment-3021717859
@alamb I've reworked this as per discussion in https://github.com/apache/datafusion/pull/16589#discussion_r2176012085. This now leaves the actual casting work up the cast functions, which means that we can do the work there and it will just trickle through to here. I do still recommend moving forward with this PR because if we ever wanted to reference `functions-nested` or similar in this predicate adaptation code we'll have to create this new module anyway. There is a world where we don't offer this rewrite by default in these APIs (which would force the whole column to be read and cast) and instead make a hook and plug it in via `SessionContext` or something like that. But I think that sounds more complicated and the downsides of having the new module are not that great (in fact there's pros for compile time, etc.). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
