andygrove commented on PR #1122:
URL:
https://github.com/apache/datafusion-comet/pull/1122#issuecomment-2960629920
I am closing this PR since it is no longer active. Feel free to re-open if
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
andygrove closed pull request #1122: feat: add expression array_size
URL: https://github.com/apache/datafusion-comet/pull/1122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
Groennbeck commented on PR #1122:
URL:
https://github.com/apache/datafusion-comet/pull/1122#issuecomment-2647707391
> Hi @Groennbeck are you still planning on update this PR?
Hey! sorry has been busy. I can have a look this week.
--
This is an automated message from the Apache Git
parthchandra commented on code in PR #1122:
URL: https://github.com/apache/datafusion-comet/pull/1122#discussion_r1934793909
##
native/spark-expr/src/list.rs:
##
@@ -708,6 +708,92 @@ impl PartialEq for ArrayInsert {
}
}
+#[derive(Debug, Hash)]
+pub struct ArraySize {
+
andygrove commented on PR #1122:
URL:
https://github.com/apache/datafusion-comet/pull/1122#issuecomment-2602875156
Hi @Groennbeck are you still planning on update this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
Groennbeck commented on PR #1122:
URL:
https://github.com/apache/datafusion-comet/pull/1122#issuecomment-2572887702
> @Groennbeck DataFusion 44.0.0 is now released
Nice! will update this later today.
--
This is an automated message from the Apache Git Service.
To respond to the mes
andygrove commented on PR #1122:
URL:
https://github.com/apache/datafusion-comet/pull/1122#issuecomment-2567147992
@Groennbeck DataFusion 44.0.0 is now released
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
andygrove commented on PR #1122:
URL:
https://github.com/apache/datafusion-comet/pull/1122#issuecomment-2515697081
> [apache/datafusion#13600](https://github.com/apache/datafusion/pull/13600)
>
> Have to wait for this to get into the next version
Thanks @Groennbeck. The next Da
Groennbeck commented on PR #1122:
URL:
https://github.com/apache/datafusion-comet/pull/1122#issuecomment-2508022496
https://github.com/apache/datafusion/pull/13600
Have to wait for this to get into the next version
--
This is an automated message from the Apache Git Service.
To res
Kimahriman commented on code in PR #1122:
URL: https://github.com/apache/datafusion-comet/pull/1122#discussion_r1862531038
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -2220,6 +2220,16 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerd
viirya commented on PR #1122:
URL:
https://github.com/apache/datafusion-comet/pull/1122#issuecomment-2503539560
Note that DataFusion `array_length`'s return type is `UInt64` but Spark's
`array_size` is Int32.
--
This is an automated message from the Apache Git Service.
To respond to the
Groennbeck commented on PR #1122:
URL:
https://github.com/apache/datafusion-comet/pull/1122#issuecomment-2503365932
> Why not to use an `array_length` from [the
Datafusion](https://datafusion.apache.org/user-guide/expressions.html#array-expressions)
instead?
>
> ```
> array_lengt
SemyonSinchenko commented on PR #1122:
URL:
https://github.com/apache/datafusion-comet/pull/1122#issuecomment-2503288806
Why not to use an `array_length` from [the
Datafusion](https://datafusion.apache.org/user-guide/expressions.html#array-expressions)
instead?
```
array_length(array
viirya commented on code in PR #1122:
URL: https://github.com/apache/datafusion-comet/pull/1122#discussion_r1859195781
##
native/spark-expr/src/list.rs:
##
@@ -708,6 +708,91 @@ impl PartialEq for ArrayInsert {
}
}
+#[derive(Debug, Hash)]
+pub struct ArraySize {
+src_
viirya commented on code in PR #1122:
URL: https://github.com/apache/datafusion-comet/pull/1122#discussion_r1859195781
##
native/spark-expr/src/list.rs:
##
@@ -708,6 +708,91 @@ impl PartialEq for ArrayInsert {
}
}
+#[derive(Debug, Hash)]
+pub struct ArraySize {
+src_
viirya commented on code in PR #1122:
URL: https://github.com/apache/datafusion-comet/pull/1122#discussion_r1859195279
##
native/spark-expr/src/list.rs:
##
@@ -708,6 +708,91 @@ impl PartialEq for ArrayInsert {
}
}
+#[derive(Debug, Hash)]
+pub struct ArraySize {
+src_
Groennbeck commented on code in PR #1122:
URL: https://github.com/apache/datafusion-comet/pull/1122#discussion_r1859192663
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -2220,6 +2220,16 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerd
viirya commented on code in PR #1122:
URL: https://github.com/apache/datafusion-comet/pull/1122#discussion_r1859163165
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -2220,6 +2220,16 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde wi
viirya commented on code in PR #1122:
URL: https://github.com/apache/datafusion-comet/pull/1122#discussion_r1859161981
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -2220,6 +2220,16 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde wi
viirya commented on code in PR #1122:
URL: https://github.com/apache/datafusion-comet/pull/1122#discussion_r1859160709
##
native/spark-expr/src/list.rs:
##
@@ -708,6 +708,92 @@ impl PartialEq for ArrayInsert {
}
}
+#[derive(Debug, Hash)]
+pub struct ArraySize {
+src_
viirya commented on code in PR #1122:
URL: https://github.com/apache/datafusion-comet/pull/1122#discussion_r1859157757
##
native/proto/src/proto/expr.proto:
##
@@ -84,6 +84,7 @@ message Expr {
GetArrayStructFields get_array_struct_fields = 57;
BinaryExpr array_append =
21 matches
Mail list logo
