viirya commented on code in PR #1122:
URL: https://github.com/apache/datafusion-comet/pull/1122#discussion_r1859163165


##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2220,6 +2220,16 @@ object QueryPlanSerde extends Logging with 
ShimQueryPlanSerde with CometExprShim
               expr.children(2))
             None
           }
+        case expr if expr.prettyName == "size" =>

Review Comment:
   Instead of matching expr name "size", we can match `Size` expression with an 
`ArrayType` input expression.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to