Re: [PR] feat: Add regexp_substr function [datafusion]

2025-04-08 Thread via GitHub
github-actions[bot] closed pull request #14323: feat: Add regexp_substr function URL: https://github.com/apache/datafusion/pull/14323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] feat: Add regexp_substr function [datafusion]

2025-03-28 Thread via GitHub
github-actions[bot] commented on PR #14323: URL: https://github.com/apache/datafusion/pull/14323#issuecomment-2763013966 Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or

Re: [PR] feat: Add regexp_substr function [datafusion]

2025-01-27 Thread via GitHub
Omega359 commented on PR #14323: URL: https://github.com/apache/datafusion/pull/14323#issuecomment-2616424423 Thank you for your contribution! I have 2 concerns: * This may be a duplicate of https://github.com/apache/datafusion/pull/14282 (more full featured though) as I think they co

Re: [PR] feat: Add regexp_substr function [datafusion]

2025-01-27 Thread via GitHub
Omega359 commented on code in PR #14323: URL: https://github.com/apache/datafusion/pull/14323#discussion_r1930892056 ## datafusion/functions/src/regex/regexpsubstr.rs: ## @@ -0,0 +1,554 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lic

Re: [PR] feat: Add regexp_substr function [datafusion]

2025-01-27 Thread via GitHub
Omega359 commented on code in PR #14323: URL: https://github.com/apache/datafusion/pull/14323#discussion_r1930887575 ## datafusion/functions/src/regex/regexpsubstr.rs: ## @@ -0,0 +1,554 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lic

Re: [PR] feat: Add regexp_substr function [datafusion]

2025-01-27 Thread via GitHub
Omega359 commented on code in PR #14323: URL: https://github.com/apache/datafusion/pull/14323#discussion_r1930885951 ## datafusion/functions/src/regex/regexpsubstr.rs: ## @@ -0,0 +1,554 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lic

Re: [PR] feat: Add regexp_substr function [datafusion]

2025-01-27 Thread via GitHub
Omega359 commented on PR #14323: URL: https://github.com/apache/datafusion/pull/14323#issuecomment-2616398145 Is this materially different than https://github.com/apache/datafusion/pull/14282 ? -- This is an automated message from the Apache Git Service. To respond to the message, please