Omega359 commented on PR #14323: URL: https://github.com/apache/datafusion/pull/14323#issuecomment-2616424423
Thank you for your contribution! I have 2 concerns: * This may be a duplicate of https://github.com/apache/datafusion/pull/14282 (more full featured though) as I think they cover the same functionality (though in a different style and under a different function name) * It seems to be based on an old version of regexpcount.rs without the updates and fixes for Utf8View, caching and updated doc style. Caching especially would be nice to have as compiling regex's is very expensive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
