alamb closed pull request #14417: feat: Add `array_min` function support
URL: https://github.com/apache/datafusion/pull/14417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
alamb commented on PR #14417:
URL: https://github.com/apache/datafusion/pull/14417#issuecomment-3016494929
Note `array_min` was completed by @dharanad in
- https://github.com/apache/datafusion/pull/16574
--
This is an automated message from the Apache Git Service.
To respond t
alamb commented on PR #14417:
URL: https://github.com/apache/datafusion/pull/14417#issuecomment-2860324372
Marking as draft as I think this PR is no longer waiting on feedback and I
am trying to make it easier to find PRs in need of review. Please mark it as
ready for review when it is read
rluvaton commented on code in PR #14417:
URL: https://github.com/apache/datafusion/pull/14417#discussion_r2035971319
##
datafusion/functions-nested/src/min.rs:
##
@@ -0,0 +1,140 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
erenavsarogullari commented on PR #14417:
URL: https://github.com/apache/datafusion/pull/14417#issuecomment-2790273589
> hey @erenavsarogullari, are you still tracking merging this ?
Yes, this PR is ready to be merged if there is not any other concern.
`array_max` function
([#14470](http
cht42 commented on PR #14417:
URL: https://github.com/apache/datafusion/pull/14417#issuecomment-2789214885
hey @erenavsarogullari, are you still tracking merging this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
erenavsarogullari commented on PR #14417:
URL: https://github.com/apache/datafusion/pull/14417#issuecomment-2692942704
I have also applied incoming feedbacks from `array_max` PR:
https://github.com/apache/datafusion/pull/14470 to here as well. Just FYI.
--
This is an automated message fro
erenavsarogullari commented on PR #14417:
URL: https://github.com/apache/datafusion/pull/14417#issuecomment-2645880016
Thanks @jayzhan211 and @findepi for the reviews.
Updated this PR in terms of previous feedback from `array_max` PR:
https://github.com/apache/datafusion/pull/14470
Pl
jayzhan211 commented on PR #14417:
URL: https://github.com/apache/datafusion/pull/14417#issuecomment-2644276922
> DuckDB has list_max, and our array semantics are supposed to model Duck's
list semantics, thus it makes sense to add to DataFusion core.
>
> Review-wise, let's do array_ma
jayzhan211 commented on PR #14417:
URL: https://github.com/apache/datafusion/pull/14417#issuecomment-2642735772
First of all, I'm not sure whether this function should be in datafusion
core or
[datafusion-functions-extra](https://github.com/datafusion-contrib/datafusion-functions-extra).
I
10 matches
Mail list logo
