jayzhan211 commented on PR #14417: URL: https://github.com/apache/datafusion/pull/14417#issuecomment-2644276922
> DuckDB has list_max, and our array semantics are supposed to model Duck's list semantics, thus it makes sense to add to DataFusion core. > > Review-wise, let's do array_max well in #14470 and then return to this PR. It doesn't make sense to review the two in parallel, since most of the comments will be the same. For example, this PR still uses sort to get minimal element. > > I would actually recommend closing this PR and creating a new afresh once array_max gets in, to avoid using old copy of the code. For DuckDB has many array functions that doesn't mean we need to port every single function to datafusion core. We only interested in function that Postgres has supported (if exists in both system that is the MUST HAVE) or function that has a large interest worths to maintain in datafusion core. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
