Re: [PR] feat: [datafusion-spark] Implement `next_day` function [datafusion]

2025-07-28 Thread via GitHub
2010YOUY01 merged PR #16780: URL: https://github.com/apache/datafusion/pull/16780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@dat

Re: [PR] feat: [datafusion-spark] Implement `next_day` function [datafusion]

2025-07-27 Thread via GitHub
petern48 commented on code in PR #16780: URL: https://github.com/apache/datafusion/pull/16780#discussion_r2234069016 ## datafusion/sqllogictest/test_files/spark/datetime/next_day.slt: ## @@ -23,5 +23,65 @@ ## Original Query: SELECT next_day('2015-01-14', 'TU'); ## PySpark 3.

Re: [PR] feat: [datafusion-spark] Implement `next_day` function [datafusion]

2025-07-27 Thread via GitHub
Standing-Man commented on code in PR #16780: URL: https://github.com/apache/datafusion/pull/16780#discussion_r2233882699 ## datafusion/sqllogictest/test_files/spark/datetime/next_day.slt: ## @@ -23,5 +23,65 @@ ## Original Query: SELECT next_day('2015-01-14', 'TU'); ## PySpar

Re: [PR] feat: [datafusion-spark] Implement `next_day` function [datafusion]

2025-07-25 Thread via GitHub
petern48 commented on PR #16780: URL: https://github.com/apache/datafusion/pull/16780#issuecomment-3121353753 Nice, I resolved the conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] feat: [datafusion-spark] Implement `next_day` function [datafusion]

2025-07-25 Thread via GitHub
2010YOUY01 commented on PR #16780: URL: https://github.com/apache/datafusion/pull/16780#issuecomment-3121286514 Thanks! I think it's ready to go after the merge conflict is resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] feat: [datafusion-spark] Implement `next_day` function [datafusion]

2025-07-25 Thread via GitHub
petern48 commented on code in PR #16780: URL: https://github.com/apache/datafusion/pull/16780#discussion_r2231556908 ## datafusion/sqllogictest/test_files/spark/datetime/next_day.slt: ## @@ -23,5 +23,17 @@ ## Original Query: SELECT next_day('2015-01-14', 'TU'); ## PySpark 3.

Re: [PR] feat: [datafusion-spark] Implement `next_day` function [datafusion]

2025-07-25 Thread via GitHub
petern48 commented on code in PR #16780: URL: https://github.com/apache/datafusion/pull/16780#discussion_r223182 ## datafusion/spark/src/function/datetime/mod.rs: ## @@ -15,11 +15,24 @@ // specific language governing permissions and limitations // under the License. +pub

Re: [PR] feat: [datafusion-spark] Implement `next_day` function [datafusion]

2025-07-15 Thread via GitHub
Omega359 commented on code in PR #16780: URL: https://github.com/apache/datafusion/pull/16780#discussion_r2207320436 ## datafusion/spark/src/function/datetime/mod.rs: ## @@ -15,11 +15,24 @@ // specific language governing permissions and limitations // under the License. +pub

Re: [PR] feat: [datafusion-spark] Implement `next_day` function [datafusion]

2025-07-15 Thread via GitHub
Omega359 commented on code in PR #16780: URL: https://github.com/apache/datafusion/pull/16780#discussion_r2207311997 ## datafusion/spark/Cargo.toml: ## @@ -37,6 +37,7 @@ name = "datafusion_spark" [dependencies] arrow = { workspace = true } +chrono.workspace = true Review Co

Re: [PR] feat: [datafusion-spark] Implement `next_day` function [datafusion]

2025-07-14 Thread via GitHub
Copilot commented on code in PR #16780: URL: https://github.com/apache/datafusion/pull/16780#discussion_r2206549032 ## datafusion/spark/src/function/datetime/next_day.rs: ## @@ -0,0 +1,255 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] feat: [datafusion-spark] Implement `next_day` function [datafusion]

2025-07-14 Thread via GitHub
2010YOUY01 commented on code in PR #16780: URL: https://github.com/apache/datafusion/pull/16780#discussion_r2206536716 ## datafusion/spark/src/function/datetime/next_day.rs: ## @@ -0,0 +1,255 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut