Standing-Man commented on code in PR #16780:
URL: https://github.com/apache/datafusion/pull/16780#discussion_r2233882699
##########
datafusion/sqllogictest/test_files/spark/datetime/next_day.slt:
##########
@@ -23,5 +23,65 @@
## Original Query: SELECT next_day('2015-01-14', 'TU');
## PySpark 3.5.5 Result: {'next_day(2015-01-14, TU)': datetime.date(2015, 1,
20), 'typeof(next_day(2015-01-14, TU))': 'date', 'typeof(2015-01-14)':
'string', 'typeof(TU)': 'string'}
Review Comment:
You can safely remove the commented-out tests, since their functionality is
already covered below.
Additionally, there appear to be some duplicate test cases in the lower
section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
