shruti2522 closed pull request #14961: datafusion-cli: add streaming state for
printing logic
URL: https://github.com/apache/datafusion/pull/14961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
zhuqi-lucas commented on code in PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#discussion_r1978574819
##
datafusion-cli/src/print_format.rs:
##
@@ -153,6 +155,164 @@ fn format_batches_with_maxrows(
Ok(())
}
+/// The state and methods for displaying outp
shruti2522 commented on code in PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#discussion_r1978519726
##
datafusion-cli/src/print_format.rs:
##
@@ -153,6 +155,164 @@ fn format_batches_with_maxrows(
Ok(())
}
+/// The state and methods for displaying outpu
shruti2522 commented on code in PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#discussion_r1978519726
##
datafusion-cli/src/print_format.rs:
##
@@ -153,6 +155,164 @@ fn format_batches_with_maxrows(
Ok(())
}
+/// The state and methods for displaying outpu
shruti2522 commented on PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#issuecomment-2696038414
Thanks @alamb, @zhuqi-lucas, I’ll rebase after PR #14953 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
alamb commented on PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#issuecomment-2695600414
Marking as draft as I think this PR is no longer waiting on feedback. Please
mark it as ready for review when it is ready for another look
--
This is an automated message from the A
alamb commented on code in PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#discussion_r1977876884
##
datafusion-cli/src/print_format.rs:
##
@@ -153,6 +155,164 @@ fn format_batches_with_maxrows(
Ok(())
}
+/// The state and methods for displaying output
Re
zhuqi-lucas commented on PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#issuecomment-2693488674
Thank you @shruti2522 for the work, we still need this feature, we revert it
due to urgent release cycle for the new feature testing and bug fixes, actually
we will add back the
shruti2522 commented on PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#issuecomment-2693447156
Hi @alamb , @zhuqi-lucas, I see that the most of the functions in the
datafusion cli print format have been reverted, do we still need these changes?
--
This is an automated mes
shruti2522 commented on PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#issuecomment-2692700043
Hi @alamb, please trigger the CI for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
10 matches
Mail list logo
