alamb commented on code in PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#discussion_r1977876884
##########
datafusion-cli/src/print_format.rs:
##########
@@ -153,6 +155,164 @@ fn format_batches_with_maxrows<W: std::io::Write>(
Ok(())
}
+/// The state and methods for displaying output
Review Comment:
This definitely looks like it is on the right track -- thank you @shruti2522
Can you perhaps try and migrate the old callsites to use this new code?
As @zhuqi-lucas mentions, there is another version of the PR here:
- https://github.com/apache/datafusion/pull/14954
I am hoping we can get the structure in
https://github.com/apache/datafusion/pull/14954 cleaner before merging. Maybe
you can help there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
