iffyio commented on PR #1900:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1900#issuecomment-2998964400
Ah yeah that's not ideal when consuming the AST, but I think we could leave
the foreign key representation as `Ident` since it maps to what's expected at
that level - it w
iffyio merged PR #1900:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
mvzink commented on PR #1900:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1900#issuecomment-2997848751
Having started using this, I noticed that it's actually fairly inconvenient
to have the `TableConstraint::ForeignKey` variant have a different type for
variants (e.g. if y
iffyio commented on code in PR #1900:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1900#discussion_r2160246517
##
src/parser/mod.rs:
##
@@ -10595,6 +10593,16 @@ impl<'a> Parser<'a> {
self.parse_parenthesized_column_list_inner(optional, allow_empty, |p|
