mvzink commented on PR #1900: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1900#issuecomment-2997848751
Having started using this, I noticed that it's actually fairly inconvenient to have the `TableConstraint::ForeignKey` variant have a different type for variants (e.g. if you want to implement `get_columns(constraint: &TableConstraint) -> &[???]`). Thoughts on using `IndexColumn` for `TableConstraint::ForeignKey` as well, even though it should aways only be plain column names? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
