alamb merged PR #1604:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr.
iffyio commented on code in PR #1604:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1604#discussion_r1896652348
##
src/ast/spans.rs:
##
@@ -2106,6 +2106,15 @@ impl Spanned for SelectInto {
}
}
+impl Spanned for UpdateTableFromKind {
+fn span(&self) ->
yuval-illumex commented on code in PR #1604:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1604#discussion_r1895655809
##
src/keywords.rs:
##
@@ -941,6 +941,7 @@ pub const RESERVED_FOR_TABLE_ALIAS: &[Keyword] = &[
// Reserved for Snowflake table sample
K
iffyio commented on code in PR #1604:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1604#discussion_r1895636641
##
src/ast/query.rs:
##
@@ -2790,3 +2790,14 @@ impl fmt::Display for ValueTableMode {
}
}
}
+
+/// The update table from options
Review
yuval-illumex commented on PR #1604:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1604#issuecomment-2558493934
@iffyio appreciate your feedback again 🙏 (Tests that are failing are not
related to my PR):
https://github.com/apache/datafusion-sqlparser-rs/actions/runs/12
yuval-illumex commented on code in PR #1604:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1604#discussion_r1894970422
##
src/parser/mod.rs:
##
@@ -11679,14 +11679,21 @@ impl<'a> Parser<'a> {
pub fn parse_update(&mut self) -> Result {
let or = self.p
yuval-illumex commented on code in PR #1604:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1604#discussion_r1894950935
##
src/parser/mod.rs:
##
@@ -11679,14 +11679,21 @@ impl<'a> Parser<'a> {
pub fn parse_update(&mut self) -> Result {
let or = self.p
iffyio commented on code in PR #1604:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1604#discussion_r1894948705
##
src/parser/mod.rs:
##
@@ -11679,14 +11679,21 @@ impl<'a> Parser<'a> {
pub fn parse_update(&mut self) -> Result {
let or = self.parse_co
yuval-illumex commented on PR #1604:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1604#issuecomment-2558434174
Thank you @iffyio for your feedback, I asked your opinion in one of the
comments.
--
This is an automated message from the Apache Git Service.
To respond to the m
yuval-illumex commented on code in PR #1604:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1604#discussion_r1894902880
##
src/parser/mod.rs:
##
@@ -11679,14 +11679,21 @@ impl<'a> Parser<'a> {
pub fn parse_update(&mut self) -> Result {
let or = self.p
yuval-illumex commented on code in PR #1604:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1604#discussion_r1894888910
##
src/parser/mod.rs:
##
@@ -11679,14 +11679,21 @@ impl<'a> Parser<'a> {
pub fn parse_update(&mut self) -> Result {
let or = self.p
iffyio commented on code in PR #1604:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1604#discussion_r1892588098
##
src/parser/mod.rs:
##
@@ -11679,14 +11679,21 @@ impl<'a> Parser<'a> {
pub fn parse_update(&mut self) -> Result {
let or = self.parse_co
12 matches
Mail list logo
