iffyio commented on code in PR #1604:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1604#discussion_r1896652348
##########
src/ast/spans.rs:
##########
@@ -2106,6 +2106,15 @@ impl Spanned for SelectInto {
}
}
+impl Spanned for UpdateTableFromKind {
+ fn span(&self) -> Span {
+ match self {
+ UpdateTableFromKind::BeforeSet(vec) => vec.span(),
+ UpdateTableFromKind::AfterSet(vec) => vec.span(),
Review Comment:
```suggestion
UpdateTableFromKind::BeforeSet(from) => from.span(),
UpdateTableFromKind::AfterSet(from) => from.span(),
```
##########
src/ast/query.rs:
##########
@@ -2790,3 +2790,16 @@ impl fmt::Display for ValueTableMode {
}
}
}
+
+/// The `FROM` clause of an `UPDATE TABLE` statement
+#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
+#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
+#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
+pub enum UpdateTableFromKind {
+ /// Update Statment where the 'FROM' clause is before the 'SET' keyword
(Supported by Snowflake)
+ /// For Example: UPDATE FROM t1 SET t1.name='aaa'
+ BeforeSet(TableWithJoins),
+ /// Update Statment where the 'FROM' clause is after the 'SET' keyword
(Which is the standard way)
+ /// For Example: UPDATE SET t1.name='aaa' FROM t1
Review Comment:
```suggestion
/// For Example: `UPDATE FROM t1 SET t1.name='aaa'`
BeforeSet(TableWithJoins),
/// Update Statment where the 'FROM' clause is after the 'SET' keyword
(Which is the standard way)
/// For Example: `UPDATE SET t1.name='aaa' FROM t1`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
