Re: [PR] Support Avg distinct [datafusion]

2025-04-05 Thread via GitHub
qazxcdswe123 closed pull request #15356: Support Avg distinct URL: https://github.com/apache/datafusion/pull/15356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] Support Avg distinct [datafusion]

2025-03-25 Thread via GitHub
qazxcdswe123 commented on PR #15356: URL: https://github.com/apache/datafusion/pull/15356#issuecomment-2750658019 Closing this as I splitted the PR into 2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Support Avg distinct [datafusion]

2025-03-24 Thread via GitHub
jayzhan211 commented on code in PR #15356: URL: https://github.com/apache/datafusion/pull/15356#discussion_r2011076901 ## datafusion/functions-aggregate/src/average.rs: ## @@ -60,6 +64,17 @@ make_udaf_expr_and_func!( avg_udaf ); +pub fn avg_distinct(expr: Expr) -> Expr {

Re: [PR] Support Avg distinct [datafusion]

2025-03-24 Thread via GitHub
qazxcdswe123 commented on code in PR #15356: URL: https://github.com/apache/datafusion/pull/15356#discussion_r2008792246 ## datafusion/functions-aggregate-common/src/aggregate/avg_distinct/decimal.rs: ## @@ -0,0 +1,133 @@ +// Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Support Avg distinct [datafusion]

2025-03-24 Thread via GitHub
qazxcdswe123 commented on code in PR #15356: URL: https://github.com/apache/datafusion/pull/15356#discussion_r2008777574 ## datafusion/sqllogictest/test_files/aggregate.slt: ## @@ -6686,3 +6688,35 @@ SELECT a, median(b), arrow_typeof(median(b)) FROM group_median_all_nulls GROUP

Re: [PR] Support Avg distinct [datafusion]

2025-03-24 Thread via GitHub
qazxcdswe123 commented on code in PR #15356: URL: https://github.com/apache/datafusion/pull/15356#discussion_r2010196071 ## datafusion/functions-aggregate-common/src/aggregate/avg_distinct/numeric.rs: ## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Support Avg distinct [datafusion]

2025-03-24 Thread via GitHub
qazxcdswe123 commented on code in PR #15356: URL: https://github.com/apache/datafusion/pull/15356#discussion_r2010124325 ## datafusion/functions-aggregate/src/average.rs: ## @@ -60,6 +64,17 @@ make_udaf_expr_and_func!( avg_udaf ); +pub fn avg_distinct(expr: Expr) -> Expr

Re: [PR] Support Avg distinct [datafusion]

2025-03-24 Thread via GitHub
jayzhan211 commented on code in PR #15356: URL: https://github.com/apache/datafusion/pull/15356#discussion_r2010093546 ## datafusion/functions-aggregate/src/average.rs: ## @@ -60,6 +64,17 @@ make_udaf_expr_and_func!( avg_udaf ); +pub fn avg_distinct(expr: Expr) -> Expr {

Re: [PR] Support Avg distinct [datafusion]

2025-03-22 Thread via GitHub
qazxcdswe123 commented on code in PR #15356: URL: https://github.com/apache/datafusion/pull/15356#discussion_r2008777574 ## datafusion/sqllogictest/test_files/aggregate.slt: ## @@ -6686,3 +6688,35 @@ SELECT a, median(b), arrow_typeof(median(b)) FROM group_median_all_nulls GROUP

Re: [PR] Support Avg distinct [datafusion]

2025-03-22 Thread via GitHub
qazxcdswe123 commented on code in PR #15356: URL: https://github.com/apache/datafusion/pull/15356#discussion_r2008792246 ## datafusion/functions-aggregate-common/src/aggregate/avg_distinct/decimal.rs: ## @@ -0,0 +1,133 @@ +// Licensed to the Apache Software Foundation (ASF) unde