qazxcdswe123 commented on code in PR #15356: URL: https://github.com/apache/datafusion/pull/15356#discussion_r2010124325
########## datafusion/functions-aggregate/src/average.rs: ########## @@ -60,6 +64,17 @@ make_udaf_expr_and_func!( avg_udaf ); +pub fn avg_distinct(expr: Expr) -> Expr { Review Comment: Indeed. I added this becuase there's a `count_distinct` https://github.com/apache/datafusion/blob/d68fca91fd4c73f2cd92d61d036bc0411a2ed826/datafusion/functions-aggregate/src/count.rs#L74 Should we deprecate this `count_distinct`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org