alamb commented on code in PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#discussion_r1972433284
##
src/ast/mod.rs:
##
@@ -8789,9 +8796,9 @@ mod tests {
#[test]
fn test_interval_display() {
let interval = Expr::Interval(Interval {
alamb commented on PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2683188897
🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
iffyio merged PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
iffyio commented on code in PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#discussion_r1969034324
##
tests/sqlparser_bigquery.rs:
##
@@ -29,19 +29,19 @@ use test_utils::*;
#[test]
fn parse_literal_string() {
let sql = concat!(
-"SELECT
lovasoa commented on code in PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#discussion_r1968471231
##
src/ast/mod.rs:
##
@@ -8789,9 +8796,9 @@ mod tests {
#[test]
fn test_interval_display() {
let interval = Expr::Interval(Interval
alamb commented on code in PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#discussion_r1968440688
##
src/ast/mod.rs:
##
@@ -8789,9 +8796,9 @@ mod tests {
#[test]
fn test_interval_display() {
let interval = Expr::Interval(Interval {
lovasoa commented on PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2679141697
It would be nice if we could get this merged before other pending PRs,
because it touches almost all the tests, and is guaranteed to generate big
conflicts as we change t
