iffyio commented on code in PR #1738:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1738#discussion_r1969034324
##########
tests/sqlparser_bigquery.rs:
##########
@@ -29,19 +29,19 @@ use test_utils::*;
#[test]
fn parse_literal_string() {
let sql = concat!(
- "SELECT ",
- "'single', ",
- r#""double", "#,
- "'''triple-single''', ",
- r#""""triple-double""", "#,
- r#"'single\'escaped', "#,
- r#"'''triple-single\'escaped''', "#,
- r#"'''triple-single'unescaped''', "#,
- r#""double\"escaped", "#,
- r#""""triple-double\"escaped""", "#,
- r#""""triple-double"unescaped""", "#,
- r#""""triple-double'unescaped""", "#,
- r#"'''triple-single"unescaped'''"#,
+ "SELECT ", // line 1, column 1
+ "'single', ", // line 1, column 7
+ r#""double", "#, // line 1, column 14
+ "'''triple-single''', ", // line 1, column 22
+ r#""""triple-double""", "#, // line 1, column 33
+ r#"'single\'escaped', "#, // line 1, column 43
+ r#"'''triple-single\'escaped''', "#, // line 1, column 55
+ r#"'''triple-single'unescaped''', "#, // line 1, column 68
+ r#""double\"escaped", "#, // line 1, column 83
+ r#""""triple-double\"escaped""", "#, // line 1, column 92
+ r#""""triple-double"unescaped""", "#, // line 1, column 105
+ r#""""triple-double'unescaped""", "#, // line 1, column 118
+ r#"'''triple-single"unescaped'''"#, // line 1, column 131
Review Comment:
do the added comments here need cleanup or do they serve a purpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
