alamb commented on PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#issuecomment-3039007195
🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
blaginin commented on PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#issuecomment-3033917307
@nirnayroy thank you so much for your work, i think that's a very useful new
function 🎉 welcome to the project!!!
--
This is an automated message from the Apache Git Service.
To r
blaginin merged PR #15928:
URL: https://github.com/apache/datafusion/pull/15928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
Omega359 commented on PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#issuecomment-3033041600
LGTM :) @blaginin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
Omega359 commented on PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#issuecomment-3032478116
Run extended tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
Omega359 commented on PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#issuecomment-3029308432
Run extended tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
Omega359 commented on PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#issuecomment-302984
Clippy failures related to rand update (I think
https://github.com/apache/datafusion/pull/16062)
--
This is an automated message from the Apache Git Service.
To respond to the mes
Omega359 commented on PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#issuecomment-3029112924
Run extended tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
alamb commented on PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#issuecomment-3029119907
> Run extended tests
It works!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
nirnayroy commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2180625721
##
datafusion/functions/src/regex/regexpinstr.rs:
##
@@ -0,0 +1,826 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
Omega359 commented on PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#issuecomment-3025423773
I'll pull this branch later this week and run the tests but in general this
PR is looking pretty good! I left a few comments/suggestions for a few things I
found from a quick review
Omega359 commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2178434012
##
datafusion/functions/src/regex/regexpinstr.rs:
##
@@ -0,0 +1,826 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lice
Omega359 commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2178426472
##
datafusion/functions/src/regex/regexpinstr.rs:
##
@@ -0,0 +1,826 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lice
Omega359 commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2178423784
##
datafusion/functions/src/regex/mod.rs:
##
@@ -89,7 +122,44 @@ pub fn functions() -> Vec> {
vec