Omega359 commented on code in PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#discussion_r2178423784
##########
datafusion/functions/src/regex/mod.rs:
##########
@@ -89,7 +122,44 @@ pub fn functions() -> Vec<Arc<datafusion_expr::ScalarUDF>> {
vec![
regexp_count(),
regexp_match(),
+ regexp_instr(),
regexp_like(),
regexp_replace(),
]
}
+
+pub fn compile_and_cache_regex<'strings, 'cache>(
+ regex: &'strings str,
+ flags: Option<&'strings str>,
+ regex_cache: &'cache mut HashMap<(&'strings str, Option<&'strings str>),
Regex>,
+) -> Result<&'cache Regex, ArrowError>
+where
+ 'strings: 'cache,
+{
+ let result = match regex_cache.entry((regex, flags)) {
+ Entry::Occupied(occupied_entry) => occupied_entry.into_mut(),
+ Entry::Vacant(vacant_entry) => {
+ let compiled = compile_regex(regex, flags)?;
+ vacant_entry.insert(compiled)
+ }
+ };
+ Ok(result)
+}
+
+pub fn compile_regex(regex: &str, flags: Option<&str>) -> Result<Regex,
ArrowError> {
+ let pattern = match flags {
+ None | Some("") => regex.to_string(),
+ Some(flags) => {
+ if flags.contains("g") {
+ return Err(ArrowError::ComputeError(
+ "regexp_count() does not support global flag".to_string(),
Review Comment:
```suggestion
"regexp_count()/regexp_instr() does not support the
global flag".to_string(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
