Re: [PR] Implement SnowFlake ALTER SESSION [datafusion-sqlparser-rs]

2025-02-20 Thread via GitHub
iffyio merged PR #1712: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

Re: [PR] Implement SnowFlake ALTER SESSION [datafusion-sqlparser-rs]

2025-02-18 Thread via GitHub
alamb commented on PR #1712: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1712#issuecomment-2666766213 Marking as draft as we sort out the CI failure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Implement SnowFlake ALTER SESSION [datafusion-sqlparser-rs]

2025-02-16 Thread via GitHub
iffyio commented on PR #1712: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1712#issuecomment-2662199671 @osipovartem could you take a look into the CI failure? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Implement SnowFlake ALTER SESSION [datafusion-sqlparser-rs]

2025-02-08 Thread via GitHub
alamb commented on PR #1712: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1712#issuecomment-2645599573 > See my comments inline. Generally speaking, I support parsing of arbitrary options using DataLoadingOptions but would rename and move this struct to a more central locati

Re: [PR] Implement SnowFlake ALTER SESSION [datafusion-sqlparser-rs]

2025-02-08 Thread via GitHub
yoavcloud commented on code in PR #1712: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1712#discussion_r1947549025 ## src/ast/mod.rs: ## @@ -2722,6 +2722,17 @@ pub enum Statement { owner: Option, }, /// ```sql +/// ALTER SESSION SET sessionP

Re: [PR] Implement SnowFlake ALTER SESSION [datafusion-sqlparser-rs]

2025-02-08 Thread via GitHub
yoavcloud commented on code in PR #1712: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1712#discussion_r1947548884 ## src/dialect/snowflake.rs: ## @@ -960,6 +980,42 @@ fn parse_stage_params(parser: &mut Parser) -> Result ] +fn parse_session_options(parser: &mut P

Re: [PR] Implement SnowFlake ALTER SESSION [datafusion-sqlparser-rs]

2025-02-08 Thread via GitHub
yoavcloud commented on code in PR #1712: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1712#discussion_r1947546222 ## src/dialect/snowflake.rs: ## @@ -120,6 +120,12 @@ impl Dialect for SnowflakeDialect { } fn parse_statement(&self, parser: &mut Parser)

Re: [PR] Implement SnowFlake ALTER SESSION [datafusion-sqlparser-rs]

2025-02-08 Thread via GitHub
yoavcloud commented on code in PR #1712: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1712#discussion_r1947546222 ## src/dialect/snowflake.rs: ## @@ -120,6 +120,12 @@ impl Dialect for SnowflakeDialect { } fn parse_statement(&self, parser: &mut Parser)

Re: [PR] Implement SnowFlake ALTER SESSION [datafusion-sqlparser-rs]

2025-02-08 Thread via GitHub
yoavcloud commented on code in PR #1712: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1712#discussion_r1947545495 ## tests/sqlparser_snowflake.rs: ## @@ -3404,3 +3404,29 @@ fn test_grant_database_role_to() { snowflake_and_generic().verified_stmt("GRANT DATAB

Re: [PR] Implement SnowFlake ALTER SESSION [datafusion-sqlparser-rs]

2025-02-08 Thread via GitHub
yoavcloud commented on code in PR #1712: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1712#discussion_r1947544999 ## tests/sqlparser_snowflake.rs: ## @@ -3404,3 +3404,29 @@ fn test_grant_database_role_to() { snowflake_and_generic().verified_stmt("GRANT DATAB

Re: [PR] Implement SnowFlake ALTER SESSION [datafusion-sqlparser-rs]

2025-02-08 Thread via GitHub
yoavcloud commented on code in PR #1712: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1712#discussion_r1947544971 ## tests/sqlparser_snowflake.rs: ## @@ -3404,3 +3404,29 @@ fn test_grant_database_role_to() { snowflake_and_generic().verified_stmt("GRANT DATAB

Re: [PR] Implement SnowFlake ALTER SESSION [datafusion-sqlparser-rs]

2025-02-07 Thread via GitHub
alamb commented on code in PR #1712: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1712#discussion_r1946963932 ## src/ast/mod.rs: ## @@ -2722,6 +2722,17 @@ pub enum Statement { owner: Option, }, /// ```sql +/// ALTER SESSION SET sessionParam

Re: [PR] Implement snowflake ALTER SESSION [datafusion-sqlparser-rs]

2025-02-06 Thread via GitHub
osipovartem closed pull request #1711: Implement snowflake ALTER SESSION URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific