yoavcloud commented on code in PR #1712:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1712#discussion_r1947549025
##########
src/ast/mod.rs:
##########
@@ -2722,6 +2722,17 @@ pub enum Statement {
owner: Option<ddl::AlterConnectorOwner>,
},
/// ```sql
+ /// ALTER SESSION SET sessionParam
+ /// ALTER SESSION UNSET <param_name> [ , <param_name> , ... ]
+ /// ```
+ /// See <https://docs.snowflake.com/en/sql-reference/sql/alter-session>
+ AlterSession {
+ /// true is to set for the session parameters, false is to unset
+ set: bool,
+ /// The session parameters to set or unset
+ session_params: DataLoadingOptions,
Review Comment:
DataLoadingOptions is a very useful struct IMO, I would rename it to
KeyValueOptions and promote it to its own helper file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
