niebayes commented on code in PR #15055:
URL: https://github.com/apache/datafusion/pull/15055#discussion_r1984349654
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -906,28 +906,43 @@ impl LogicalPlan {
let equi_expr_count = on.len();
assert!
jonahgao commented on PR #15055:
URL: https://github.com/apache/datafusion/pull/15055#issuecomment-2707863018
Thanks @delamarch3 @niebayes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
jonahgao merged PR #15055:
URL: https://github.com/apache/datafusion/pull/15055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
jonahgao commented on code in PR #15055:
URL: https://github.com/apache/datafusion/pull/15055#discussion_r1985168916
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -917,17 +917,16 @@ impl LogicalPlan {
// The first part of expr is equi-exprs,
delamarch3 commented on PR #15055:
URL: https://github.com/apache/datafusion/pull/15055#issuecomment-2706220468
Thanks for the reviews, I've pushed up your suggestions @jonahgao @niebayes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
niebayes commented on code in PR #15055:
URL: https://github.com/apache/datafusion/pull/15055#discussion_r1984351304
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -4630,4 +4645,125 @@ digraph {
let parameter_type =
params.clone().get(placeholder_value).unwrap().cl
jonahgao commented on code in PR #15055:
URL: https://github.com/apache/datafusion/pull/15055#discussion_r1984343133
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -906,28 +906,43 @@ impl LogicalPlan {
let equi_expr_count = on.len();
assert!
