jonahgao commented on code in PR #15055:
URL: https://github.com/apache/datafusion/pull/15055#discussion_r1985168916
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -917,17 +917,16 @@ impl LogicalPlan {
// The first part of expr is equi-exprs,
// and the struct of each equi-expr is like `left-expr =
right-expr`.
assert_eq!(expr.len(), equi_expr_count);
- let new_on = expr.into_iter().map(|equi_expr| {
+ let mut new_on = Vec::new();
Review Comment:
nit: use `with_capacity` would be preferable.
```rust
let mut new_on = Vec::with_capacity(on.len());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
