alamb merged PR #16744:
URL: https://github.com/apache/datafusion/pull/16744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #16744:
URL: https://github.com/apache/datafusion/pull/16744#issuecomment-3063812572
Thank you @XiangpengHao
FYI @NGA-TRAN and @LiaCastaneda
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
alamb commented on code in PR #16744:
URL: https://github.com/apache/datafusion/pull/16744#discussion_r2201840244
##
datafusion/proto/tests/cases/roundtrip_physical_plan.rs:
##
@@ -1739,7 +1739,7 @@ async fn roundtrip_physical_plan_node() {
}
// Failing due to https://github
XiangpengHao commented on PR #16744:
URL: https://github.com/apache/datafusion/pull/16744#issuecomment-3062721623
> @XiangpengHao: If you believe the round-trip bug reproduced in
`test_round_trip_tpch_queries` from PR #16742 is distinct, we can file a
separate issue and tackle it independen
XiangpengHao commented on PR #16744:
URL: https://github.com/apache/datafusion/pull/16744#issuecomment-3062727458
> > @adriangb can you take a look if this is the right way to fix it?
>
> I took an initial look and... I'm a bit stumped. I don't fully understand
where this is running o
NGA-TRAN commented on PR #16744:
URL: https://github.com/apache/datafusion/pull/16744#issuecomment-3062503974
@XiangpengHao: If you believe the round-trip bug reproduced in
`test_round_trip_tpch_queries` from PR #16742 is distinct, we can file a
separate issue and tackle it independently. @
adriangb commented on PR #16744:
URL: https://github.com/apache/datafusion/pull/16744#issuecomment-3062283423
> @adriangb can you take a look if this is the right way to fix it?
I took an initial look and... I'm a bit stumped. I don't fully understand
where this is running or how. Wha
NGA-TRAN commented on PR #16744:
URL: https://github.com/apache/datafusion/pull/16744#issuecomment-3062022168
Thanks @XiangpengHao for the fix. Could you also run the tests [in this
PR](https://github.com/apache/datafusion/pull/16742)? The deserialization bug
only happens to 1 tpc-h queries
XiangpengHao commented on PR #16744:
URL: https://github.com/apache/datafusion/pull/16744#issuecomment-3059497366
Ok I run a bisect and find the code is broken since #15769, I guess it's
because the filter is moved to a different sub-structure.
@adriangb can you take a look if this is
