XiangpengHao commented on PR #16744: URL: https://github.com/apache/datafusion/pull/16744#issuecomment-3062727458
> > @adriangb can you take a look if this is the right way to fix it? > > I took an initial look and... I'm a bit stumped. I don't fully understand where this is running or how, I haven't looked too deeply into proto serialization of plans and I don't know if DataDog is doing that before or after optimizer rules are applied, etc. What I'll say about #15769 is that it shouldn't have changed the structure of `FilterExec`. It just moves the filters from `FilterExec` into `ParquetSource`. In other words: the plan is being rewritten in the optimizer pass, but I think the final state of the ExecutionPlan tree should not have changed in terms of serialization. > > But I think I need to take another look at this. > > I'll be completely AFK for the the weekend until Tuesday and have an early end to my day today so if I don't get back to give a deeper analysis for this I suggest that as long as: > > 1. This fixes the tests. > 2. Does not break any other tests (especially [Add serialization/deserialization and round-trip tests for all tpc-h queries #16742](https://github.com/apache/datafusion/pull/16742)). > > It's worth just proceeding with it and I can try to find a deeper meaning to it next week. > > Might also be worth asking Claude to explain _why_ this is the fix to give us pointers into what to look at? Agree! I think it's not that https://github.com/apache/datafusion/pull/15769 introduces the bug, it just surfaces up the bug. I plan to dig deeper on this over the weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
