Re: [PR] Fix broken `serde` feature [datafusion]

2025-03-14 Thread via GitHub
alamb commented on PR #15124: URL: https://github.com/apache/datafusion/pull/15124#issuecomment-2724651837 Backport PR: - https://github.com/apache/datafusion/pull/15227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Fix broken `serde` feature [datafusion]

2025-03-11 Thread via GitHub
alamb commented on PR #15124: URL: https://github.com/apache/datafusion/pull/15124#issuecomment-2714425431 Thanks again @vadimpiven and @Weijun-H -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Fix broken `serde` feature [datafusion]

2025-03-11 Thread via GitHub
alamb merged PR #15124: URL: https://github.com/apache/datafusion/pull/15124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Fix broken `serde` feature [datafusion]

2025-03-11 Thread via GitHub
alamb commented on code in PR #15124: URL: https://github.com/apache/datafusion/pull/15124#discussion_r1989263174 ## datafusion/core/tests/core_integration.rs: ## @@ -42,8 +42,13 @@ mod custom_sources_cases; /// Run all tests that are found in the `optimizer` directory mod opt

Re: [PR] Fix broken `serde` feature [datafusion]

2025-03-11 Thread via GitHub
alamb commented on code in PR #15124: URL: https://github.com/apache/datafusion/pull/15124#discussion_r1989207663 ## datafusion/core/tests/serde.rs: ## @@ -0,0 +1,34 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. Se

Re: [PR] Fix broken `serde` feature [datafusion]

2025-03-11 Thread via GitHub
alamb commented on code in PR #15124: URL: https://github.com/apache/datafusion/pull/15124#discussion_r1989043718 ## .github/workflows/rust.yml: ## @@ -184,6 +184,8 @@ jobs: rust-version: stable - name: Run tests (excluding doctests) run: cargo test --

Re: [PR] Fix broken `serde` feature [datafusion]

2025-03-11 Thread via GitHub
vadimpiven commented on PR #15124: URL: https://github.com/apache/datafusion/pull/15124#issuecomment-2713794854 Merged main to trigger CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Fix broken `serde` feature [datafusion]

2025-03-11 Thread via GitHub
vadimpiven commented on PR #15124: URL: https://github.com/apache/datafusion/pull/15124#issuecomment-2713103636 Tests failed because of “no space left on device” error. Can someone please restart it? -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Fix broken `serde` feature [datafusion]

2025-03-10 Thread via GitHub
vadimpiven commented on code in PR #15124: URL: https://github.com/apache/datafusion/pull/15124#discussion_r1988170629 ## datafusion/core/Cargo.toml: ## @@ -79,7 +79,7 @@ recursive_protection = [ "datafusion-physical-optimizer/recursive_protection", "datafusion-sql/rec

Re: [PR] Fix broken `serde` feature [datafusion]

2025-03-10 Thread via GitHub
vadimpiven commented on PR #15124: URL: https://github.com/apache/datafusion/pull/15124#issuecomment-2712113391 @Weijun-H added test, please check that it is in the correct place. Also I was not sure if I should make a separate pipeline invocation, please let me know if I should -- This