alamb commented on code in PR #15124: URL: https://github.com/apache/datafusion/pull/15124#discussion_r1989207663
########## datafusion/core/tests/serde.rs: ########## @@ -0,0 +1,34 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +/// Ensure `serde` feature from `arrow-schema` crate is re-exported. Review Comment: I consolidated this into the `core_integration` binary so we didn't have to build a new target to test this ``` andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion$ cargo test --test core_integration --features=serde -- serde Compiling datafusion v46.0.0 (/Users/andrewlamb/Software/datafusion/datafusion/core) Finished `test` profile [unoptimized + debuginfo] target(s) in 8.36s Running tests/core_integration.rs (target/debug/deps/core_integration-acc990c95fa5aa49) running 1 test test serde::ensure_serde_support ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 567 filtered out; finished in 0.00s andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion$ cargo test --test core_integration -- serde Compiling datafusion v46.0.0 (/Users/andrewlamb/Software/datafusion/datafusion/core) Finished `test` profile [unoptimized + debuginfo] target(s) in 2.68s Running tests/core_integration.rs (target/debug/deps/core_integration-370a90f8f594db8d) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 567 filtered out; finished in 0.00s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
