Re: [PR] Fix array_agg memory over accounting [datafusion]

2025-06-10 Thread via GitHub
gabotechs commented on code in PR #16346: URL: https://github.com/apache/datafusion/pull/16346#discussion_r2137044002 ## datafusion/common/src/scalar/mod.rs: ## @@ -3525,6 +3525,12 @@ impl ScalarValue { } } } + +/// Compacts ([ScalarValue::compact]

Re: [PR] Fix array_agg memory over accounting [datafusion]

2025-06-09 Thread via GitHub
LiaCastaneda commented on code in PR #16346: URL: https://github.com/apache/datafusion/pull/16346#discussion_r2135765414 ## datafusion/common/src/scalar/mod.rs: ## @@ -3525,6 +3525,12 @@ impl ScalarValue { } } } + +/// Compacts ([ScalarValue::compa

Re: [PR] Fix array_agg memory over accounting [datafusion]

2025-06-09 Thread via GitHub
gabotechs commented on code in PR #16346: URL: https://github.com/apache/datafusion/pull/16346#discussion_r2135657546 ## datafusion/functions-aggregate/src/array_agg.rs: ## @@ -313,7 +315,8 @@ impl Accumulator for ArrayAggAccumulator { }; if !val.is_empty() {