gabotechs commented on code in PR #16346:
URL: https://github.com/apache/datafusion/pull/16346#discussion_r2137044002
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -3525,6 +3525,12 @@ impl ScalarValue {
}
}
}
+
+ /// Compacts ([ScalarValue::compact]) the current [ScalarValue] and
returns it.
+ pub fn compacted(mut self) -> Self {
Review Comment:
🤔 I don't have enough evidence to justify that #[inline] is better here, the
function is not really in the hot path of any operation, if you ask me I'd just
trust the compiler to do what's right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
