kevinjqliu commented on PR #1010:
URL:
https://github.com/apache/datafusion-python/pull/1010#issuecomment-2643950080
@timsaucer im still seeing this issue on my local setup.
Following the same steps as the CI test
https://github.com/apache/datafusion-python/blob/93ac6a820353b3ddea014be1
kevinjqliu commented on PR #1010:
URL:
https://github.com/apache/datafusion-python/pull/1010#issuecomment-2643889554
> Is it possible there's an issue with your submodule that contains the
data? It looks like CI unit tests are passing also.
I think thats the issue, i didnt see that `
timsaucer merged PR #1010:
URL: https://github.com/apache/datafusion-python/pull/1010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
kevinjqliu commented on PR #1010:
URL:
https://github.com/apache/datafusion-python/pull/1010#issuecomment-2643887392
I double checked by running that test with v44.1.0 and the plans are the
same
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
kevinjqliu commented on PR #1010:
URL:
https://github.com/apache/datafusion-python/pull/1010#issuecomment-2643871160
cool as long as CI works, i think we're ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
timsaucer commented on PR #1010:
URL:
https://github.com/apache/datafusion-python/pull/1010#issuecomment-2643862582
Do you think this is ready? If so and you move it out of draft I can merge
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
timsaucer commented on PR #1010:
URL:
https://github.com/apache/datafusion-python/pull/1010#issuecomment-2643740088
@kevinjqliu Are you getting an error on this unit test? I'm seeing it pass.
Is it possible there's an issue with your submodule that contains the data? It
looks like CI unit
kevinjqliu commented on PR #1010:
URL:
https://github.com/apache/datafusion-python/pull/1010#issuecomment-2643727227
Thank you @timsaucer i verified locally that that indeed resolved the issue
for `test_string_functions`
I also pushed up a fix for `test_relational_expr` (which was o
timsaucer commented on PR #1010:
URL:
https://github.com/apache/datafusion-python/pull/1010#issuecomment-2643548740
@kevinjqliu I just pushed to your branch an update to the return type. As
we've been updating we've seen a lot of these small changes from string ->
string_view.
--
This
kevinjqliu commented on PR #1010:
URL:
https://github.com/apache/datafusion-python/pull/1010#issuecomment-2643430035
Interesting... CI was previously passing when using the branch-45 commit
hash...
`test_string_functions` errors on comparison
https://github.com/apache/datafusion-
kevinjqliu commented on PR #1010:
URL:
https://github.com/apache/datafusion-python/pull/1010#issuecomment-2629787697
Converted to draft for now, blocked until datafusion v45 is published
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kevinjqliu commented on code in PR #1010:
URL:
https://github.com/apache/datafusion-python/pull/1010#discussion_r1938699415
##
Cargo.toml:
##
@@ -35,13 +35,13 @@ substrait = ["dep:datafusion-substrait"]
[dependencies]
tokio = { version = "1.42", features = ["macros", "rt",
timsaucer commented on PR #1010:
URL:
https://github.com/apache/datafusion-python/pull/1010#issuecomment-2629590542
Thank you for taking this on! It looks like a smooth update!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
timsaucer commented on code in PR #1010:
URL:
https://github.com/apache/datafusion-python/pull/1010#discussion_r1938599713
##
Cargo.toml:
##
@@ -35,13 +35,13 @@ substrait = ["dep:datafusion-substrait"]
[dependencies]
tokio = { version = "1.42", features = ["macros", "rt", "
timsaucer commented on code in PR #1010:
URL:
https://github.com/apache/datafusion-python/pull/1010#discussion_r1938599194
##
Cargo.toml:
##
@@ -17,7 +17,7 @@
[package]
name = "datafusion-python"
-version = "43.0.0"
+version = "45.0.0"
Review Comment:
I think we want to
timsaucer commented on code in PR #1010:
URL:
https://github.com/apache/datafusion-python/pull/1010#discussion_r1938599063
##
examples/ffi-table-provider/Cargo.toml:
##
@@ -21,15 +21,15 @@ version = "0.1.0"
edition = "2021"
[dependencies]
-datafusion = { version = "44.0.0"
kevinjqliu commented on code in PR #1010:
URL:
https://github.com/apache/datafusion-python/pull/1010#discussion_r1938551798
##
Cargo.toml:
##
@@ -17,7 +17,7 @@
[package]
name = "datafusion-python"
-version = "43.0.0"
+version = "45.0.0"
Review Comment:
we might want to
kevinjqliu commented on code in PR #1010:
URL:
https://github.com/apache/datafusion-python/pull/1010#discussion_r1938551460
##
examples/ffi-table-provider/Cargo.toml:
##
@@ -21,15 +21,15 @@ version = "0.1.0"
edition = "2021"
[dependencies]
-datafusion = { version = "44.0.0"
kevinjqliu commented on code in PR #1010:
URL:
https://github.com/apache/datafusion-python/pull/1010#discussion_r1938548438
##
Cargo.toml:
##
@@ -35,13 +35,13 @@ substrait = ["dep:datafusion-substrait"]
[dependencies]
tokio = { version = "1.42", features = ["macros", "rt",
kevinjqliu commented on code in PR #1010:
URL:
https://github.com/apache/datafusion-python/pull/1010#discussion_r1938548438
##
Cargo.toml:
##
@@ -35,13 +35,13 @@ substrait = ["dep:datafusion-substrait"]
[dependencies]
tokio = { version = "1.42", features = ["macros", "rt",
20 matches
Mail list logo
