kevinjqliu commented on PR #1010: URL: https://github.com/apache/datafusion-python/pull/1010#issuecomment-2643727227
Thank you @timsaucer i verified locally that that indeed resolved the issue for `test_string_functions` I also pushed up a fix for `test_relational_expr` (which was originally changed [here](https://github.com/apache/datafusion-python/commit/3c662010f9d133cda65749b119a1b1731edbe4e5#diff-a4447eee51f8b342595263292ff35d53615d3049170d293d642a911656b78fb7L144) but now im reverting that change) There's one last issue with [`test_execution_plan`](https://github.com/apache/datafusion-python/blob/93ac6a820353b3ddea014be1eddad8bd004b0fce/python/tests/test_dataframe.py#L730-L764), `stream = ctx.execute(plan, 0)` produce no data. I think it has to do with the plan itself. I've printed out the plans here. Im not familiar with this, could you help take a look? ``` (Pdb) print(plan.display()) AggregateExec: mode=FinalPartitioned, gby=[c1@0 as c1], aggr=[sum(test.c2)] (Pdb) print(plan.display_indent()) AggregateExec: mode=FinalPartitioned, gby=[c1@0 as c1], aggr=[sum(test.c2)] CoalesceBatchesExec: target_batch_size=8192 RepartitionExec: partitioning=Hash([c1@0], 8), input_partitions=8 AggregateExec: mode=Partial, gby=[c1@0 as c1], aggr=[sum(test.c2)] RepartitionExec: partitioning=RoundRobinBatch(8), input_partitions=1 CsvExec: file_groups={1 group: [[Users/kevinliu/repos/datafusion-python/testing/data/csv/aggregate_test_100.csv]]}, projection=[c1, c2], has_header=true ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
