Re: [PR] Add support for `ORDER BY ALL` [datafusion-sqlparser-rs]

2025-02-21 Thread via GitHub
iffyio merged PR #1724: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

Re: [PR] Add support for `ORDER BY ALL` [datafusion-sqlparser-rs]

2025-02-20 Thread via GitHub
iffyio commented on PR #1724: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1724#issuecomment-2673590812 @PokIsemaine could you look into the merge conflicts on the branch when you get the time? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Add support for `ORDER BY ALL` [datafusion-sqlparser-rs]

2025-02-20 Thread via GitHub
iffyio commented on code in PR #1724: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1724#discussion_r1963056561 ## src/dialect/duckdb.rs: ## @@ -89,4 +89,9 @@ impl Dialect for DuckDbDialect { fn supports_from_first_select(&self) -> bool { true }

Re: [PR] Add support for `ORDER BY ALL` [datafusion-sqlparser-rs]

2025-02-20 Thread via GitHub
iffyio commented on code in PR #1724: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1724#discussion_r1963053134 ## src/parser/mod.rs: ## @@ -9191,17 +9191,31 @@ impl<'a> Parser<'a> { pub fn parse_optional_order_by(&mut self) -> Result, ParserError> {

Re: [PR] Add support for `ORDER BY ALL` [datafusion-sqlparser-rs]

2025-02-19 Thread via GitHub
PokIsemaine commented on code in PR #1724: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1724#discussion_r1962907240 ## src/parser/mod.rs: ## @@ -9191,17 +9191,31 @@ impl<'a> Parser<'a> { pub fn parse_optional_order_by(&mut self) -> Result, ParserError> {

Re: [PR] Add support for `ORDER BY ALL` [datafusion-sqlparser-rs]

2025-02-19 Thread via GitHub
PokIsemaine commented on code in PR #1724: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1724#discussion_r1962885448 ## src/parser/mod.rs: ## @@ -13405,6 +13419,19 @@ impl<'a> Parser<'a> { }) } +pub fn parse_order_by_all(&mut self) -> Result {

Re: [PR] Add support for `ORDER BY ALL` [datafusion-sqlparser-rs]

2025-02-19 Thread via GitHub
PokIsemaine commented on code in PR #1724: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1724#discussion_r1962883847 ## src/parser/mod.rs: ## @@ -9191,17 +9191,31 @@ impl<'a> Parser<'a> { pub fn parse_optional_order_by(&mut self) -> Result, ParserError> {

Re: [PR] Add support for `ORDER BY ALL` [datafusion-sqlparser-rs]

2025-02-19 Thread via GitHub
PokIsemaine commented on code in PR #1724: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1724#discussion_r1962888283 ## src/dialect/duckdb.rs: ## @@ -89,4 +89,9 @@ impl Dialect for DuckDbDialect { fn supports_from_first_select(&self) -> bool { true

Re: [PR] Add support for `ORDER BY ALL` [datafusion-sqlparser-rs]

2025-02-19 Thread via GitHub
PokIsemaine commented on code in PR #1724: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1724#discussion_r1962883847 ## src/parser/mod.rs: ## @@ -9191,17 +9191,31 @@ impl<'a> Parser<'a> { pub fn parse_optional_order_by(&mut self) -> Result, ParserError> {

Re: [PR] Add support for `ORDER BY ALL` [datafusion-sqlparser-rs]

2025-02-16 Thread via GitHub
iffyio commented on code in PR #1724: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1724#discussion_r1957698799 ## src/parser/mod.rs: ## @@ -13405,6 +13419,19 @@ impl<'a> Parser<'a> { }) } +pub fn parse_order_by_all(&mut self) -> Result { Revi

Re: [PR] Add support for `ORDER BY ALL` [datafusion-sqlparser-rs]

2025-02-14 Thread via GitHub
iffyio commented on code in PR #1724: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1724#discussion_r1956406082 ## src/ast/query.rs: ## @@ -2205,31 +2205,50 @@ pub enum JoinConstraint { #[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)] #[cfg_attr(fea

Re: [PR] Add support for `ORDER BY ALL` [datafusion-sqlparser-rs]

2025-02-13 Thread via GitHub
PokIsemaine commented on code in PR #1724: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1724#discussion_r1955496661 ## src/parser/mod.rs: ## @@ -9183,17 +9183,19 @@ impl<'a> Parser<'a> { pub fn parse_optional_order_by(&mut self) -> Result, ParserError> {

Re: [PR] Add support for `ORDER BY ALL` [datafusion-sqlparser-rs]

2025-02-13 Thread via GitHub
PokIsemaine commented on code in PR #1724: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1724#discussion_r1955494712 ## src/ast/query.rs: ## @@ -2205,31 +2205,50 @@ pub enum JoinConstraint { #[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)] #[cfg_att

Re: [PR] Add support for `ORDER BY ALL` [datafusion-sqlparser-rs]

2025-02-13 Thread via GitHub
PokIsemaine commented on code in PR #1724: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1724#discussion_r1955495623 ## src/ast/query.rs: ## @@ -2205,31 +2205,50 @@ pub enum JoinConstraint { #[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)] #[cfg_att

Re: [PR] Add support for `ORDER BY ALL` [datafusion-sqlparser-rs]

2025-02-12 Thread via GitHub
iffyio commented on code in PR #1724: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1724#discussion_r1952866285 ## src/ast/query.rs: ## @@ -2205,31 +2205,50 @@ pub enum JoinConstraint { #[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)] #[cfg_attr(fea