PokIsemaine commented on code in PR #1724:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1724#discussion_r1962885448
##########
src/parser/mod.rs:
##########
@@ -13405,6 +13419,19 @@ impl<'a> Parser<'a> {
})
}
+ pub fn parse_order_by_all(&mut self) -> Result<OrderByAll, ParserError> {
Review Comment:
You are right, this change is better. I plan to first change `pub fn
parse_order_by_all` to `fn parse_order_by_options` and then reuse it in
`parse_order_by_expr`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
