acking-you commented on code in PR #15462:
URL: https://github.com/apache/datafusion/pull/15462#discussion_r2031035548
##
datafusion/physical-expr/src/expressions/binary.rs:
##
@@ -805,6 +811,47 @@ impl BinaryExpr {
}
}
+/// Check if it meets the short-circuit condition
acking-you commented on PR #15462:
URL: https://github.com/apache/datafusion/pull/15462#issuecomment-2783526836
> The only thing I think is needed for this PR is to either
>
> 1. remove the bechmark
> 2. update the benchmark ti actually test `BinaryExpr` evaluation time
done
berkaysynnada commented on code in PR #15462:
URL: https://github.com/apache/datafusion/pull/15462#discussion_r2034007815
##
datafusion/physical-expr/src/expressions/binary.rs:
##
@@ -805,6 +811,47 @@ impl BinaryExpr {
}
}
+/// Check if it meets the short-circuit conditi
berkaysynnada commented on code in PR #15462:
URL: https://github.com/apache/datafusion/pull/15462#discussion_r2034007019
##
datafusion/physical-expr/src/expressions/binary.rs:
##
@@ -805,6 +811,47 @@ impl BinaryExpr {
}
}
+/// Check if it meets the short-circuit conditi
alamb commented on PR #15462:
URL: https://github.com/apache/datafusion/pull/15462#issuecomment-2787055441
the extended tests appear to be failing after this PR:
- https://github.com/apache/datafusion/issues/15641
--
This is an automated message from the Apache Git Service.
To respond t
alamb commented on code in PR #15462:
URL: https://github.com/apache/datafusion/pull/15462#discussion_r2033602903
##
datafusion/physical-expr/src/expressions/binary.rs:
##
@@ -805,6 +811,47 @@ impl BinaryExpr {
}
}
+/// Check if it meets the short-circuit condition
+///
acking-you commented on code in PR #15462:
URL: https://github.com/apache/datafusion/pull/15462#discussion_r2033205911
##
datafusion/physical-expr/src/expressions/binary.rs:
##
@@ -805,6 +811,47 @@ impl BinaryExpr {
}
}
+/// Check if it meets the short-circuit condition
berkaysynnada commented on code in PR #15462:
URL: https://github.com/apache/datafusion/pull/15462#discussion_r2033185234
##
datafusion/physical-expr/src/expressions/binary.rs:
##
@@ -805,6 +811,47 @@ impl BinaryExpr {
}
}
+/// Check if it meets the short-circuit conditi
acking-you commented on code in PR #15462:
URL: https://github.com/apache/datafusion/pull/15462#discussion_r2033160515
##
datafusion/physical-expr/src/expressions/binary.rs:
##
@@ -805,6 +811,47 @@ impl BinaryExpr {
}
}
+/// Check if it meets the short-circuit condition
berkaysynnada commented on code in PR #15462:
URL: https://github.com/apache/datafusion/pull/15462#discussion_r2033101460
##
datafusion/physical-expr/src/expressions/binary.rs:
##
@@ -805,6 +811,47 @@ impl BinaryExpr {
}
}
+/// Check if it meets the short-circuit conditi
alamb commented on code in PR #15462:
URL: https://github.com/apache/datafusion/pull/15462#discussion_r2032964400
##
datafusion/physical-expr/benches/binary_op.rs:
##
@@ -0,0 +1,373 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
alamb commented on PR #15462:
URL: https://github.com/apache/datafusion/pull/15462#issuecomment-2786029908
Filed https://github.com/apache/datafusion/issues/15631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
alamb merged PR #15462:
URL: https://github.com/apache/datafusion/pull/15462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #15462:
URL: https://github.com/apache/datafusion/pull/15462#issuecomment-2786018330
Thanks again for the wonderful work @acking-you --
I ran the benchmarks locally and indeed they show a non trivial amount of
time being spent in count_ones.
