alamb commented on PR #15462: URL: https://github.com/apache/datafusion/pull/15462#issuecomment-2786018330
Thanks again for the wonderful work @acking-you -- I ran the benchmarks locally and indeed they show a non trivial amount of time being spent in count_ones.  I also confirmed that without the short circuit optimization the benchmarks get much much slower ``` Gnuplot not found, using plotters backend bench_all_false_and time: [503.28 µs 505.29 µs 507.36 µs] change: [+1711392% +1718962% +1727169%] (p = 0.00 < 0.05) Performance has regressed. Found 7 outliers among 100 measurements (7.00%) 5 (5.00%) high mild 2 (2.00%) high severe bench_all_true_or time: [504.57 µs 506.27 µs 508.10 µs] change: [+1704732% +1713204% +1721665%] (p = 0.00 < 0.05) Performance has regressed. Found 7 outliers among 100 measurements (7.00%) 6 (6.00%) high mild ``` Let's merge this PR in and I will file a follow on ticket to track potentially improving performance even more -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
