timsaucer merged PR #1062:
URL: https://github.com/apache/datafusion-python/pull/1062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
Spaarsh commented on PR #1062:
URL:
https://github.com/apache/datafusion-python/pull/1062#issuecomment-2729797059
@timsaucer there are still several rules to be enabled. But those require
significant changes. Take a look at the rule `PLR0913`:
```
docs/source/conf.py:76:5: PLR0913 Too
timsaucer commented on PR #1062:
URL:
https://github.com/apache/datafusion-python/pull/1062#issuecomment-2729760767
Thank you for all the work on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
timsaucer commented on PR #1062:
URL:
https://github.com/apache/datafusion-python/pull/1062#issuecomment-2729223711
Since we know this PR only addresses a portion of the rules we're working
on, it seems perfectly reasonable to put it back into the ignore list for now.
--
This is an autom
Spaarsh commented on PR #1062:
URL:
https://github.com/apache/datafusion-python/pull/1062#issuecomment-2727025175
The errors are due to one of the rules I enabled in one of my commits
`SIM102`. Since I have some 10 other ruff rules to enable anyway, should I
disable this one for now?
--
timsaucer commented on PR #1062:
URL:
https://github.com/apache/datafusion-python/pull/1062#issuecomment-2727021187
I’m not sure then. I’m away for the weekend and won’t be able to test until
Monday. I can see then if I can reproduce.
--
This is an automated message from the Apache Git S
Spaarsh commented on PR #1062:
URL:
https://github.com/apache/datafusion-python/pull/1062#issuecomment-2727019630
The workflow is using `0.9.1` and I `pip install` the same. Still I don't
see any errors on my local tests.
--
This is an automated message from the Apache Git Service.
To re
timsaucer commented on PR #1062:
URL:
https://github.com/apache/datafusion-python/pull/1062#issuecomment-2727017583
You may be using a different version of ruff. These do change from time to
time as new lints get added in.
--
This is an automated message from the Apache Git Service.
To r
Spaarsh commented on PR #1062:
URL:
https://github.com/apache/datafusion-python/pull/1062#issuecomment-2727017123
I don't understand why the ruff tests are failing. My local ruff check shows
no errors.
--
This is an automated message from the Apache Git Service.
To respond to the message
timsaucer commented on code in PR #1062:
URL:
https://github.com/apache/datafusion-python/pull/1062#discussion_r1996771284
##
examples/python-udf-comparisons.py:
##
@@ -163,9 +163,9 @@ def udf_using_pyarrow_compute_impl(
resultant_arr = pc.and_(resultant_arr, filtered_
10 matches
Mail list logo
