Spaarsh commented on PR #1062:
URL:
https://github.com/apache/datafusion-python/pull/1062#issuecomment-2729797059
@timsaucer there are still several rules to be enabled. But those require
significant changes. Take a look at the rule `PLR0913`:
```
docs/source/conf.py:76:5: PLR0913 Too many arguments in function definition
(6 > 5)
|
76 | def autoapi_skip_member_fn(app, what, name, obj, skip, options) ->
bool: # noqa: ARG001
| ^^^^^^^^^^^^^^^^^^^^^^ PLR0913
77 | skip_contents = [
78 | # Re-exports
|
```
This would require us to restructure these functions. There are 15 such
errors.
Then there is rule `ERA001` that requires us to remove commented out code.
Should I focus on enabling all rules anyway or should I consider the returns
that we get on implementing these rules and proceed only if they are meaningful?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
