kosiew commented on code in PR #1019:
URL:
https://github.com/apache/datafusion-python/pull/1019#discussion_r1952245124
##
python/tests/test_functions.py:
##
@@ -1173,3 +1173,57 @@ def test_between_default(df):
actual = df.collect()[0].to_pydict()
assert actual == e
kosiew commented on code in PR #1019:
URL:
https://github.com/apache/datafusion-python/pull/1019#discussion_r2068558333
##
python/tests/test_functions.py:
##
@@ -1236,3 +1236,57 @@ def test_between_default(df):
def test_alias_with_metadata(df):
df = df.select(f.alias(f.co
kosiew commented on PR #1019:
URL:
https://github.com/apache/datafusion-python/pull/1019#issuecomment-2723770280
[The upstream PR for
fill_null](https://github.com/apache/datafusion/pull/14769) is included in
datafusion 46.0.0.
We can revisit this when datafusion-python upgrade the depe
kosiew commented on PR #1019:
URL:
https://github.com/apache/datafusion-python/pull/1019#issuecomment-2709822987
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
timsaucer commented on PR #1019:
URL:
https://github.com/apache/datafusion-python/pull/1019#issuecomment-2708285597
Hi @kosiew I moved this to draft since it looks like you're doing a good job
on the upstream work which would change how we would want to handle this.
--
This is an automat
kosiew commented on code in PR #1019:
URL:
https://github.com/apache/datafusion-python/pull/1019#discussion_r1952245124
##
python/tests/test_functions.py:
##
@@ -1173,3 +1173,57 @@ def test_between_default(df):
actual = df.collect()[0].to_pydict()
assert actual == e
