kosiew commented on code in PR #1019:
URL:
https://github.com/apache/datafusion-python/pull/1019#discussion_r1952245124
##########
python/tests/test_functions.py:
##########
@@ -1173,3 +1173,57 @@ def test_between_default(df):
actual = df.collect()[0].to_pydict()
assert actual == expected
+
+
+def test_coalesce(df):
+ # Create a DataFrame with null values
+ ctx = SessionContext()
+ batch = pa.RecordBatch.from_arrays(
+ [
+ pa.array(["Hello", None, "!"]), # string column with null
+ pa.array([4, None, 6]), # integer column with null
+ pa.array(["hello ", None, " !"]), # string column with null
+ pa.array(
+ [datetime(2022, 12, 31), None, datetime(2020, 7, 2)]
+ ), # datetime with null
+ pa.array([False, None, True]), # boolean column with null
+ ],
+ names=["a", "b", "c", "d", "e"],
+ )
+ df_with_nulls = ctx.create_dataframe([[batch]])
+
+ # Test coalesce with different data types
+ result_df = df_with_nulls.select(
+ f.coalesce(column("a"), literal("default")).alias("a_coalesced"),
+ f.coalesce(column("b"), literal(0)).alias("b_coalesced"),
+ f.coalesce(column("c"), literal("default")).alias("c_coalesced"),
+ f.coalesce(column("d"), literal(datetime(2000, 1,
1))).alias("d_coalesced"),
+ f.coalesce(column("e"), literal(False)).alias("e_coalesced"),
+ )
+
+ result = result_df.collect()[0]
+
+ # Verify results
+ assert result.column(0) == pa.array(
+ ["Hello", "default", "!"], type=pa.string_view()
+ )
+ assert result.column(1) == pa.array([4, 0, 6], type=pa.int64())
+ assert result.column(2) == pa.array(
+ ["hello ", "default", " !"], type=pa.string_view()
+ )
+ assert result.column(3) == pa.array(
+ [datetime(2022, 12, 31), datetime(2000, 1, 1), datetime(2020, 7, 2)],
+ type=pa.timestamp("us"),
+ )
+ assert result.column(4) == pa.array([False, False, True], type=pa.bool_())
+
+ # Test multiple arguments
+ result_df = df_with_nulls.select(
+ f.coalesce(column("a"), literal(None), literal("fallback")).alias(
+ "multi_coalesce"
+ )
Review Comment:
I could not find tests for coalesce which I used for fill_null, so I added
these
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
