alamb commented on issue #13853:
URL: https://github.com/apache/datafusion/issues/13853#issuecomment-2643646150
After releasing version 45 the docs are back ❤ 👓
https://docs.rs/datafusion-substrait/latest/datafusion_substrait/
does seem
wackywendell commented on issue #13853:
URL: https://github.com/apache/datafusion/issues/13853#issuecomment-2583541476
FYI - the similar changes for `substrait-validator` attached to
https://github.com/substrait-io/substrait-validator/issues/355 does seem to
have fixed [the
docs](https://d
alamb closed issue #13853: datafusion-substrait API docs on docs.rs are broken
URL: https://github.com/apache/datafusion/issues/13853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
alamb commented on issue #13853:
URL: https://github.com/apache/datafusion/issues/13853#issuecomment-2578342385
> We could just add that directive to datafusion/substrait/Cargo.toml and
see if it fixes it in the next version? Any other ideas?
This sounds like a great idea to me -- tha
wackywendell commented on issue #13853:
URL: https://github.com/apache/datafusion/issues/13853#issuecomment-2578203665
After looking more closely, it looks like `datafusion-substrait` has a
`protoc` feature:
https://github.com/apache/datafusion/blob/7af6aa9e51fde2bbf7a12c4096e999041ef6f
wackywendell commented on issue #13853:
URL: https://github.com/apache/datafusion/issues/13853#issuecomment-2578118272
Ah! We just ran into this in
https://github.com/substrait-io/substrait-validator/issues/355, and like
`substrait-rs`, added a `protoc` feature for using `protobuf-src` to g
westonpace commented on issue #13853:
URL: https://github.com/apache/datafusion/issues/13853#issuecomment-255844
Here's the relevant bit:
https://github.com/substrait-io/substrait-rs/blob/bbcc9f6d0b084a13706f39a43bbba9d37bf2a959/build.rs#L285
--
This is an automated message from the A
westonpace commented on issue #13853:
URL: https://github.com/apache/datafusion/issues/13853#issuecomment-255722
> One thing I couldn't understand is how substrait the substrait docs
themselves are built, seemingly just fine on docs.rs (the same runners)
@alamb oh, interesting. I
alamb commented on issue #13853:
URL: https://github.com/apache/datafusion/issues/13853#issuecomment-2557940944
Also, randomly, I learned today that @andygrove *also* is an owner of the
substrait crate. Fascinating!
https://github.com/user-attachments/assets/ffc7bf3e-7858-4539-b98c-c8
alamb commented on issue #13853:
URL: https://github.com/apache/datafusion/issues/13853#issuecomment-2557940737
Thanks @westonpace
One thing I couldn't understand is how substrait the substrait docs
themselves are built, seemingly just fine on docs.rs (the same runners):
https://do
westonpace commented on issue #13853:
URL: https://github.com/apache/datafusion/issues/13853#issuecomment-2557416340
Ah, yes, according to https://github.com/rust-lang/crates-build-env it does
appear that `docs.rs` uses Ubuntu 22.04 to build crate docs.
--
This is an automated message fro
westonpace commented on issue #13853:
URL: https://github.com/apache/datafusion/issues/13853#issuecomment-2557413683
A recent change was made to Substrait that used a feature that was only
stabilized in protoc versions greater than 3.12 (I'm not actually sure the
exact version it was staili
alamb commented on issue #13853:
URL: https://github.com/apache/datafusion/issues/13853#issuecomment-2555887311
Looks like it is trying to compile substrait 0.45 but itself seems to build
just fine:
https://docs.rs/substrait/0.45.5/substrait/index.html
--
This is an automated messa
14 matches
Mail list logo
