Re: [I] Redundancy/Repeated calls in query function [datafusion]

alamb closed issue #14448: Redundancy/Repeated calls in query function URL: https://github.com/apache/datafusion/issues/14448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Redundancy/Repeated calls in query function [datafusion]

alamb commented on issue #14448: URL: https://github.com/apache/datafusion/issues/14448#issuecomment-2690446778 So it seems like the consensus is that this is working as expected Given that this repeated evaluation happens only in the error case, I don't think there are any performanc

Re: [I] Redundancy/Repeated calls in query function [datafusion]

LukMRVC commented on issue #14448: URL: https://github.com/apache/datafusion/issues/14448#issuecomment-2688185305 Yes, that's what happening as I mentioned in my [previous comment](https://github.com/apache/datafusion/issues/14448#issuecomment-2685336819). When `ConstEvaluator` is t

Re: [I] Redundancy/Repeated calls in query function [datafusion]

jayzhan211 commented on issue #14448: URL: https://github.com/apache/datafusion/issues/14448#issuecomment-2687958935 I check `simplify_with_cycle_count` with the query `select to_timestamp('1')` https://github.com/apache/datafusion/blob/fc2fbb3d6b3aded73f1b0902168e008e580c89c1/datafus

Re: [I] Redundancy/Repeated calls in query function [datafusion]

jayzhan211 commented on issue #14448: URL: https://github.com/apache/datafusion/issues/14448#issuecomment-2687908244 I notice this before, I think this is something to be optimized "if possible". -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [I] Redundancy/Repeated calls in query function [datafusion]

LukMRVC commented on issue #14448: URL: https://github.com/apache/datafusion/issues/14448#issuecomment-2687834215 So, I'm not sure about the next steps towards resolving this issue. It seems, that this is actually a case of "working as expected", however I recognize that it may be a bit cou

Re: [I] Redundancy/Repeated calls in query function [datafusion]

LukMRVC commented on issue #14448: URL: https://github.com/apache/datafusion/issues/14448#issuecomment-2685336819 Hello, so I took a look at it. In the `to_timestamp` case it seems, the UDFScalar `invoke_with_args` is called from a `ConstEvaluator` when an `ExprSimplifier` is trying to

Re: [I] Redundancy/Repeated calls in query function [datafusion]

LukMRVC commented on issue #14448: URL: https://github.com/apache/datafusion/issues/14448#issuecomment-2685337303 Take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [I] Redundancy/Repeated calls in query function [datafusion]

alamb commented on issue #14448: URL: https://github.com/apache/datafusion/issues/14448#issuecomment-2643832838 Thanks @TheBitsmith -- it would be great if you could post any information you are able to find out to this ticket (like what the stack traces are) -- This is an automated mes

Re: [I] Redundancy/Repeated calls in query function [datafusion]

TheBitsmith commented on issue #14448: URL: https://github.com/apache/datafusion/issues/14448#issuecomment-2637972090 Take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [I] Redundancy/Repeated calls in query function [datafusion]

alamb commented on issue #14448: URL: https://github.com/apache/datafusion/issues/14448#issuecomment-2636669236 I think figuring out where the code is being called is a great first issue. Depending on the answer to that this might be "working as expected" or a bug to fix further -- This

Re: [I] Redundancy/Repeated calls in query function [datafusion]

alamb commented on issue #14448: URL: https://github.com/apache/datafusion/issues/14448#issuecomment-2636663137 I think the next step to debug this would be to run this test under a debugger or print out the stack somehow to see from where this function is being called -- This is