jayzhan211 commented on issue #14448:
URL: https://github.com/apache/datafusion/issues/14448#issuecomment-2687958935

   I check `simplify_with_cycle_count` with the query `select to_timestamp('1')`
   
   
https://github.com/apache/datafusion/blob/fc2fbb3d6b3aded73f1b0902168e008e580c89c1/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs#L193-L223
   
   I think the Transformed might not be correct, the Expr is unchanged but 
`transformed` is true
   
   ```
   expr: to_timestamp(Utf8("1"))
   invoke_with_args timestamp is called
   transformed_expr: to_timestamp(Utf8("1"))
   transformed: true
   expr: to_timestamp(Utf8("1"))
   invoke_with_args timestamp is called
   transformed_expr: to_timestamp(Utf8("1"))
   transformed: true
   expr: to_timestamp(Utf8("1"))
   invoke_with_args timestamp is called
   transformed_expr: to_timestamp(Utf8("1"))
   transformed: true
   expr: to_timestamp(Utf8("1"))
   invoke_with_args timestamp is called
   transformed_expr: to_timestamp(Utf8("1"))
   transformed: true
   expr: to_timestamp(Utf8("1"))
   invoke_with_args timestamp is called
   transformed_expr: to_timestamp(Utf8("1"))
   transformed: true
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to