Re: [I] Read string as Utf8View in sqllogictest [datafusion]

2025-01-27 Thread via GitHub
alamb commented on issue #13408: URL: https://github.com/apache/datafusion/issues/13408#issuecomment-2616133089 I am not sure if you have seen the great `string` patter in sqllogictest from @goldmedal yet: https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest/test_files/st

Re: [I] Read string as Utf8View in sqllogictest [datafusion]

2024-12-17 Thread via GitHub
alamb commented on issue #13408: URL: https://github.com/apache/datafusion/issues/13408#issuecomment-2548321977 > The first approach 100% Likewise, I think the first approach is good -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [I] Read string as Utf8View in sqllogictest [datafusion]

2024-11-16 Thread via GitHub
findepi commented on issue #13408: URL: https://github.com/apache/datafusion/issues/13408#issuecomment-2480677400 > statement ok > create table t(a varchar) as values ('1'), ('2'); > > query T > select arrow_typeof(a) from t; > > Utf8View > Utf8View if the ta

Re: [I] Read string as Utf8View in sqllogictest [datafusion]

2024-11-16 Thread via GitHub
Weijun-H commented on issue #13408: URL: https://github.com/apache/datafusion/issues/13408#issuecomment-2480566068 vote for 1st approach -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] Read string as Utf8View in sqllogictest [datafusion]

2024-11-15 Thread via GitHub
Omega359 commented on issue #13408: URL: https://github.com/apache/datafusion/issues/13408#issuecomment-2479593569 The first approach 100% -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] Read string as Utf8View in sqllogictest [datafusion]

2024-11-14 Thread via GitHub
jayzhan211 commented on issue #13408: URL: https://github.com/apache/datafusion/issues/13408#issuecomment-2477619868 Now I would prefer the first approach since string view type is more to a "physical type" concept, add this to parser doesn't fit very well. -- This is an automated message