alamb commented on issue #13408: URL: https://github.com/apache/datafusion/issues/13408#issuecomment-2616133089
I am not sure if you have seen the great `string` patter in sqllogictest from @goldmedal yet: https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest/test_files/string Basically it lets you write one set of tests and then verify those tests work with all the different types of string array (Utf8, Utf8View, LargeUtf8View, Dictionary(...), etc) If this ticket is just about making it easier to write slt tests, I think the `string` tests might be enough However, at least part of this ticket seems to be suggesting changing what Arrow DataType is used for `varchar` -- if that is what you are proposing then I think the `string` slt is not enough 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
