alamb closed issue #13519: Add `SessionConfig` reference to `ScalarFunctionArgs`
URL: https://github.com/apache/datafusion/issues/13519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
alamb commented on issue #13519:
URL: https://github.com/apache/datafusion/issues/13519#issuecomment-3155850517
Closed in https://github.com/apache/datafusion/pull/16970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
findepi commented on issue #13519:
URL: https://github.com/apache/datafusion/issues/13519#issuecomment-3034712766
BTW i solved my problem by adding the needed fields into the UDF struct
during it construction and then I don't need any more info at simplify() &
invoke() time. When doing so,
alamb commented on issue #13519:
URL: https://github.com/apache/datafusion/issues/13519#issuecomment-3029293964
> In light of a push to reduce breaking changes like
https://github.com/apache/datafusion/issues/16622 (and
https://github.com/apache/datafusion/pull/16078,
https://github.com/ap
findepi commented on issue #13519:
URL: https://github.com/apache/datafusion/issues/13519#issuecomment-3022377661
> Exposing sub-configs such SqlParserOptions, ExplainOptions, or
OptimizerOptions to UDFs looks like breaking abstractions, or invitation to
break abstractions.
In li
alamb commented on issue #13519:
URL: https://github.com/apache/datafusion/issues/13519#issuecomment-2527739183
> Not really, DataType has no nullable info, we have to send nullable to
ScalarFunctionArgs
As I was thinking about the nullable info that is part of embedded `Field`s
--
jayzhan211 commented on issue #13519:
URL: https://github.com/apache/datafusion/issues/13519#issuecomment-2526557445
Not really, `DataType` has no nullable info, we have to send `nullable` to
`ScalarFunctionArgs`
https://github.com/apache/datafusion/blob/6c9355d5be8b6045865fed67cb6d0
alamb commented on issue #13519:
URL: https://github.com/apache/datafusion/issues/13519#issuecomment-2525851924
> I guess we can also add `nullable` info to `ScalarFunctionArgs` #11923
It might already be present in `ScalarFunctionArgs::data_type` 🤔 :
https://github.com/apache/datafus
jayzhan211 commented on issue #13519:
URL: https://github.com/apache/datafusion/issues/13519#issuecomment-2525424413
I guess we can also add `nullable` info to `ScalarFunctionArgs`
https://github.com/apache/datafusion/issues/11923
--
This is an automated message from the Apache Git Se
Omega359 commented on issue #13519:
URL: https://github.com/apache/datafusion/issues/13519#issuecomment-2494038740
I mistyped above - I meant we couldn't use SessionContext, not
SessionConfig. Sorry about the confusion.
--
This is an automated message from the Apache Git Service.
To respo
alamb commented on issue #13519:
URL: https://github.com/apache/datafusion/issues/13519#issuecomment-2494024621
> It makes sense to me to move `SessionConfig` to common or common-runtime
crate
I agree
--
This is an automated message from the Apache Git Service.
To respond to the m
Omega359 commented on issue #13519:
URL: https://github.com/apache/datafusion/issues/13519#issuecomment-2494020943
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
jayzhan211 commented on issue #13519:
URL: https://github.com/apache/datafusion/issues/13519#issuecomment-2492804399
I think it makes sense to me to move `SessionConfig` to common crate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Omega359 commented on issue #13519:
URL: https://github.com/apache/datafusion/issues/13519#issuecomment-2491869009
We could but it wouldn't solve the issue. The issue is PhysicalExpr requires
implementations to impl Eq and Hash or to have implementations for DynEq and
DynHash. That is fine
Omega359 commented on issue #13519:
URL: https://github.com/apache/datafusion/issues/13519#issuecomment-2491816690
Started delving into this trying to find a good way to impl. Trying to add
`config_options: ConfigOptions` to `ScalarFunctionExpr` Having lots of fun with
eq and hash with Sess
Omega359 commented on issue #13519:
URL: https://github.com/apache/datafusion/issues/13519#issuecomment-2491743869
Well, small issue. `ScalarFunctionArgs` is in `datafusion-expr` which can't
use `SessionConfig` directly since it's in `datafusion-execution` which depends
on `datafusion-expr`
niebayes commented on issue #13519:
URL: https://github.com/apache/datafusion/issues/13519#issuecomment-2491762972
Great work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
17 matches
Mail list logo
